fix(sql-editor): prevent Last Id paging from skipping rows - #388
Draft
cursor[bot] wants to merge 3 commits into
Draft
fix(sql-editor): prevent Last Id paging from skipping rows#388cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Last Id paging inferred result uniqueness from any table name substring in the SQL. Joins can emit several rows for one primary-key value, so advancing with
WHERE id > last_idsilently skipped the remaining joined rows. Prefix table names could also borrow uniqueness metadata from the wrong cached table.Fix
Only enable keyset paging when the statement resolves unambiguously to one cached table and has no join, APPLY, comma-FROM, or set operation. Ambiguous queries safely retain OFFSET paging.
Validation
npx vitest run: 265 files passed, 3,621 tests passedcd apps/web && npx tsc --noEmit