Repository navigation
feat(pruner): add default resource limits to controller and webhook - #4066
infernus01 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
==========================================
- Coverage 27.79% 27.75% -0.04%
==========================================
Files 477 478 +1
Lines 25691 25727 +36
==========================================
Hits 7140 7140
- Misses 17822 17858 +36
Partials 729 729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b3d1d85 to
b0050f9
Compare
b0050f9 to
ff5b47f
Compare
|
/lgtm |
|
@infernus01 Please addd release note |
ff5b47f to
d9e55fe
Compare
|
/lgtm |
d9e55fe to
e5ee754
Compare
|
New changes are detected. LGTM label has been removed. |
|
/approve |
| ) | ||
|
|
||
| // addDefaultResourceLimits injects pruner-specific resource limits. | ||
| func addDefaultResourceLimits() mf.Transformer { |
There was a problem hiding this comment.
please Move injection into common.AddDefaultResourceRequirements(map[string]ResourceRequirements) and keep values in pruner defaults.go
|
/approve cancel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
e5ee754 to
af31c19
Compare
af31c19 to
ed3735c
Compare
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
ed3735c to
5c94388
Compare
Summary
Adds default resource requests and limits for
tekton-pruner-controllerandtekton-pruner-webhookdeployments in the operator.Changes
Modified
pkg/reconciler/kubernetes/tektonpruner/transform.goto include a newaddDefaultResourceLimits()transformer that injects defaultresource specifications:
tekton-pruner-controller
tekton-pruner-webhook
Rationale
Benchmark data: Testing showed the pruner controller uses 846-1126 MB heap memory when tracking 26k-38k resident PipelineRuns in its informer cache.
Override Mechanism
These defaults can be overridden via TektonConfig or TektonPruner CR:
The transformer runs before the options transformer, so user-specified values take precedence.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes