Repository navigation
fix(deps): bump OTel SDK with knative.dev/pkg semconv alignment - #441
Closed
infernus01 wants to merge 1 commit into
Closed
infernus01 wants to merge 1 commit into
infernus01 wants to merge 1 commit into
Conversation
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 50.40% 50.40%
=======================================
Files 19 19
Lines 2113 2113
=======================================
Hits 1065 1065
Misses 916 916
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bumps knative.dev/pkg to v0.0.0-20260918182429-5dc1978f0042to address a startup panic caused by conflicting OpenTelemetry schema URLs.
The dependabot next dependency combination uses OTel components with different schema versions: https://opentelemetry.io/schemas/1.43.0 and https://opentelemetry.io/schemas/1.41.0. At startup, knative.dev/pkg/observability/resource.Default() calls resource.Merge(), which detects the conflicting schema URLs and panics (exit code 2, CrashLoopBackOff).
Fix: Align the knative.dev/pkg dependency with the OTel SDK version used by the application so that observability resources use a consistent schema URL and the controller can start successfully.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes