Synchronize executor fixture with process completion - #451
Merged
Merged
Conversation
Co-authored-by: Michiel Westerbeek <happylinks@gmail.com>
Co-authored-by: Michiel Westerbeek <happylinks@gmail.com>
Replace timing assumptions with a fixture handshake and bounded completion checks, preserving stream and terminal replay assertions. Co-authored-by: Michiel Westerbeek <happylinks@gmail.com>
Contributor
Author
🤖 OS review · approve · quality 5/5 · risk lowSafe to merge. The test waits on a file handshake and the real 🟢 Risk low · recovery in minutes Reviewed |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only prerequisite for #444.
Only
executors/local.test.tschanges. No production behavior, test timeout, or test filtering changes.Verification
runningwhere it expectedexitedafter its fixed delay. Its executor implementation and fixture matched main; the test does not import the rate-limit implementation.OPENSESSION_TEST_JOBS=2 bun run check: formatting, typecheck, compiler/lint, 912 isolated unit-test files, and the strict transcript snapshot file (7 tests, 16 assertions) passed.This uses disposable local child processes only. No deployment or external provider verification is needed for this test-only change.
Started by worker bks-91461095-5061-7e84-8295-b4a5341aced2 (scheduled) in this OS session