Skip to content

Synchronize executor fixture with process completion - #451

Merged
happylinks merged 3 commits into
mainfrom
go-through-all-issues-on-the
Sep 26, 2026
Merged

happylinks merged 3 commits into
mainfrom
go-through-all-issues-on-the

Conversation

@open-session-os-tella-dev

Copy link
Copy Markdown
Contributor

Summary

Test-only prerequisite for #444.

  • Replace the executor stream test's fixed sleeps with a file handshake between the first and second writes and the existing bounded completion helper.
  • Wait for the actual terminal status, not an assumption that the child process has closed after 100 ms.
  • Retain every stream identity, sequence, exit-code and terminal replay assertion. Check intermediate batches and accumulated output too, so polling cannot hide lost output.

Only executors/local.test.ts changes. No production behavior, test timeout, or test filtering changes.

Verification

  • The original fixture observed running where it expected exited after its fixed delay. Its executor implementation and fixture matched main; the test does not import the rate-limit implementation.
  • Focused isolated executor tests: 22 passed, 63 assertions.
  • Full OPENSESSION_TEST_JOBS=2 bun run check: formatting, typecheck, compiler/lint, 912 isolated unit-test files, and the strict transcript snapshot file (7 tests, 16 assertions) passed.
  • Independent read-only review confirmed the original assertions remain intact.

This uses disposable local child processes only. No deployment or external provider verification is needed for this test-only change.

Started by worker bks-91461095-5061-7e84-8295-b4a5341aced2 (scheduled) in this OS session

open-session-os-tella-dev Bot and others added 3 commits September 25, 2026 09:37
Co-authored-by: Michiel Westerbeek <happylinks@gmail.com>
Co-authored-by: Michiel Westerbeek <happylinks@gmail.com>
Replace timing assumptions with a fixture handshake and bounded completion checks, preserving stream and terminal replay assertions.

Co-authored-by: Michiel Westerbeek <happylinks@gmail.com>
@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 OS review · approve · quality 5/5 · risk low

Safe to merge. The test waits on a file handshake and the real exited status instead of fixed sleeps, and every original stream and replay assertion is kept.

🟢 Risk low · recovery in minutes
The change touches only a test file, so a revert leaves no persisted state or delivered output behind.

Reviewed f94046c · Opus 5.5 · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
opensession Ready Ready Preview Sep 26, 2026 4:18am UTC

@happylinks
happylinks merged commit e0bb7b8 into main Sep 26, 2026
7 checks passed

This branch was successfully deployed

1 active deployment
Preview — f94046c1 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant