Skip to content

Require Go 1.26.8 to build the command generator - #114

Merged
jeri-temporal merged 1 commit into
mainfrom
harry/go-toolchain-for-gen
Sep 17, 2026
Merged

jeri-temporal merged 1 commit into
mainfrom
harry/go-toolchain-for-gen

Conversation

@hsadoyan

@hsadoyan hsadoyan commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

make gen clones temporalio/cli and installs gen-commands from it. That module now requires Go 1.26.8, and CI derives its Go version from go.mod with GOTOOLCHAIN=local, so verify-generation fails before it can build the tool.

Regenerating with the current gen-commands produces no change to commands.gen.go.

🤖 Generated with Claude Code

Stack created with GitHub Stacks CLIGive Feedback 💬

`make gen` clones temporalio/cli and installs gen-commands from it. That
module now requires Go 1.26.8, and CI derives its Go version from this
file with GOTOOLCHAIN=local, so generation cannot install its own tool.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hsadoyan
hsadoyan requested a review from a team as a code owner September 17, 2026 17:35
@hsadoyan
hsadoyan deployed to integration September 17, 2026 17:35 — with GitHub Actions Active
@hsadoyan
hsadoyan added this pull request to stack #115 September 17, 2026 17:35
@hsadoyan hsadoyan changed the title harry/go toolchain for gen Require Go 1.26.8 to build the command generator Sep 17, 2026
@jeri-temporal
jeri-temporal merged commit 76b4968 into main Sep 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants