Skip to content

Move Nexus workflow update and signal logic into the Nexus package. - #1771

Draft
VegetarianOrc wants to merge 3 commits into
mainfrom
amazzeo/nexus-workflow-update-signal-context
Draft

Move Nexus workflow update and signal logic into the Nexus package.#1771
VegetarianOrc wants to merge 3 commits into
mainfrom
amazzeo/nexus-workflow-update-signal-context

Conversation

@VegetarianOrc

Copy link
Copy Markdown
Contributor

What was changed

Moved Nexus-specific workflow update, signal, and signal-with-start logic into the Nexus operation context.

  • Apply Nexus request IDs, completion callbacks, and links for workflow updates from the active Nexus context.
  • Capture workflow update and signal response links through the Nexus package.
  • Forward inbound Nexus links for signal and signal-with-start requests through the Nexus package.
  • Remove Nexus-specific private arguments from WorkflowHandle._start_update and StartWorkflowUpdateInput.

Why?

This keeps Nexus concerns out of the general client API and interceptor inputs while preserving link propagation, callback behavior, and request deduplication. It extends the pattern established for workflow starts in #1765 and matches the newer standalone activity implementation.

Checklist

  1. Second half of Standardize Nexus Client Interactions #1716

  2. How was this tested:

  • poe test -s tests/nexus/test_link_propagation.py
  • poe test -s tests/nexus/test_signal_link_propagation_e2e.py
  • poe lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant