Move Nexus workflow update and signal logic into the Nexus package. - #1771
Draft
VegetarianOrc wants to merge 3 commits into
Draft
Move Nexus workflow update and signal logic into the Nexus package.#1771VegetarianOrc wants to merge 3 commits into
VegetarianOrc wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Moved Nexus-specific workflow update, signal, and signal-with-start logic into the Nexus operation context.
WorkflowHandle._start_updateandStartWorkflowUpdateInput.Why?
This keeps Nexus concerns out of the general client API and interceptor inputs while preserving link propagation, callback behavior, and request deduplication. It extends the pattern established for workflow starts in #1765 and matches the newer standalone activity implementation.
Checklist
Second half of Standardize Nexus Client Interactions #1716
How was this tested:
poe test -s tests/nexus/test_link_propagation.pypoe test -s tests/nexus/test_signal_link_propagation_e2e.pypoe lint