Skip to content

Preserve buffered Queries and Workflow Tasks - #1626

Closed
mcaxtr wants to merge 1 commit into
temporalio:mainfrom
mcaxtr:fix/preserve-query-obligations
Closed

mcaxtr wants to merge 1 commit into
temporalio:mainfrom
mcaxtr:fix/preserve-query-obligations

Conversation

@mcaxtr

@mcaxtr mcaxtr commented Oct 3, 2026 •

Copy link
Copy Markdown

Keep pending legacy Queries in FIFO order and retain completion-returned and polled Workflow Tasks in separate bounded slots. This preserves each retained request's response token while Queries run before the next task advances workflow history.

Transfer the complete buffer through eviction and cache admission. While full history is fetched, retain later work for the same run and preserve the selected task's source if it must wait for cache capacity. Continue buffered work after a task's history fetch fails.

Worker regressions cover task replacement, Query ordering, eviction, delayed completion responses, history admission, cache capacity, response tokens and slot release. Both SDK audience changelogs describe the observable behavior.

Validation: 14 focused Worker tests; 1,062 workspace tests with experimental; cargo lint; cargo test-lint; 568 integration tests via cargo integ-test; nightly formatting and whitespace checks.

@mcaxtr
mcaxtr requested a review from a team as a code owner October 3, 2026 02:07
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mcaxtr
mcaxtr force-pushed the fix/preserve-query-obligations branch from b42678f to b94b9e4 Compare October 3, 2026 12:33
@mcaxtr mcaxtr changed the title Preserve pending Queries across task supersession and eviction Preserve buffered Queries and Workflow Tasks Oct 3, 2026
@mcaxtr
mcaxtr force-pushed the fix/preserve-query-obligations branch from b94b9e4 to 3c24f57 Compare October 3, 2026 14:17
@chris-olszewski

This comment was marked as outdated.

@Sushisource

Copy link
Copy Markdown
Member

Closing in favor of #1693 which is much simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants