Skip to content

Add Required PR Checks job to gate merges - #1695

Open
cconstable wants to merge 2 commits into
mainfrom
core-required-checks
Open

cconstable wants to merge 2 commits into
mainfrom
core-required-checks

Conversation

@cconstable

Copy link
Copy Markdown
Contributor

What was changed

  • Added a Required PR Checks job to per-pr.yml. It runs after the jobs that are required to merge today and fails if any of them failed or was cancelled.
  • Moved the heavy tests from heavy.yml into per-pr.yml as Heavy Tests, since a job can only wait on jobs in its own file.
  • The macos-intel runs of unit and integration tests become required. They already run on every PR, and a job can only wait on a whole matrix job, not on individual entries.

Why?

Branch protection lists required checks by exact name, including one per OS for unit and integration tests. Any CI change also needs a branch protection change made at the same moment. With one roll-up job, those changes only touch this repo. Branch protection will be switched to require only Required PR Checks after this merges.

Comment on lines +356 to +357
build-and-test:
name: Heavy Tests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to move this into this file so the required-pr-checks check can reference it in it's needs: block

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yaml ID for this job is a bit weird now though. Should change to heavy-tests or something

@cconstable
cconstable marked this pull request as ready for review October 21, 2026 19:25
@cconstable
cconstable requested a review from a team as a code owner October 21, 2026 19:25

@chris-olszewski chris-olszewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sushisource's comment still stands. A byproduct of this is I will finally just kill the macos-intel job since that was previously non-blocking and this makes it blocking.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants