Repository navigation
Add Required PR Checks job to gate merges - #1695
Open
cconstable wants to merge 2 commits into
Open
cconstable wants to merge 2 commits into
cconstable wants to merge 2 commits into
Conversation
cconstable
commented
Oct 21, 2026
Comment on lines
+356
to
+357
| build-and-test: | ||
| name: Heavy Tests |
Contributor
Author
There was a problem hiding this comment.
needed to move this into this file so the required-pr-checks check can reference it in it's needs: block
Member
There was a problem hiding this comment.
The yaml ID for this job is a bit weird now though. Should change to heavy-tests or something
cconstable
marked this pull request as ready for review
October 21, 2026 19:25
chris-olszewski
approved these changes
Oct 22, 2026
chris-olszewski
left a comment
Member
There was a problem hiding this comment.
@Sushisource's comment still stands. A byproduct of this is I will finally just kill the macos-intel job since that was previously non-blocking and this makes it blocking.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Required PR Checksjob to per-pr.yml. It runs after the jobs that are required to merge today and fails if any of them failed or was cancelled.Heavy Tests, since a job can only wait on jobs in its own file.Why?
Branch protection lists required checks by exact name, including one per OS for unit and integration tests. Any CI change also needs a branch protection change made at the same moment. With one roll-up job, those changes only touch this repo. Branch protection will be switched to require only
Required PR Checksafter this merges.