Repository navigation
feat: add external storage runner - #1696
Merged
Merged
Conversation
jmaeagle99
force-pushed
the
extstore-foundation
branch
7 times, most recently
from
October 22, 2026 19:56
0ce814d to
4d36a8a
Compare
jmaeagle99
force-pushed
the
extstore-foundation
branch
from
October 22, 2026 20:18
4d36a8a to
3293372
Compare
jmaeagle99
marked this pull request as ready for review
October 22, 2026 20:24
Sushisource
reviewed
Oct 22, 2026
Sushisource
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds the external storage runner: the passes that move payloads to and from a storage driver, and the reference detection they depend on.
ExternalStorageRunneroffloads eligible payloads from a message on the way out and resolves references back to their payloads on the way in.Why?
External storage (keeping large payloads out of history by offloading them to a user-supplied driver) has to apply the same offload and retrieval steps at every worker and client path that sends or receives payloads: measure against the threshold, group by driver, and swap references for payloads. This runner is that logic in one place, so those paths call a single component instead of each reimplementing it.
Out of scope
Deliberately not in this change, so the runner can land first:
Checklist
How was this tested: unit tests covering both directions over real messages and payload slices, plus
cargo +nightly fmt --check,cargo lint, clippy, andcargo testwith and withoutexperimental.Any docs updates needed? No