Repository navigation
[NEEDS REVIEW] Upgrade MUI to v7 - #908
Conversation
Bump @mui/material, @mui/icons-material, and @mui/lab to v7; move MUI and Emotion to peerDependencies so consumers provide a single copy. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
To increment version on merge, please add one of |
|
@codex review |
|
publish rc |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
publish rc |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ice1080
added
minor
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 162cf710db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Summary
This is the first step toward the MUI v9 upgrade proposed in #745. Going straight to v9 is blocked on
material-react-table, which still passes props that MUI v9 removes (InputProps,SelectProps,MenuListProps, ...). MUI v7 still accepts those props, so this PR stops at v7.@mui/material/@mui/icons-materialgo from 6 to 7.3, and@mui/labto 7.0.1-beta.@mui/x-date-pickersstays on 8, which supports MUI 7.StyledEngineProvideris now imported from@mui/material/styles, because v7 dropped the old export.@mui/material,@mui/icons-material,@mui/x-date-pickers,@emotion/reactand@emotion/styledmove fromdependenciestopeerDependencies, and todevDependenciesfor local development. Before, if the consuming app used a different MUI major, a second copy of MUI was installed, and the app'sThemeProviderand Terraware palette augmentation didn't reach these components. Consumers now provide MUI themselves (>=7.3.11, which@mui/labrequires). This ships as a minor release.terraware-web bumps MUI to v7 together with this version in terraware/terraware-web#6865, which was tested against RC
5.1.9-rc.1.Link to Devin session: https://app.devin.ai/sessions/c03e57fefa74429eb1cdcc7d4218c11f
Open in Devin Desktop: https://app.devin.ai/desktop/session/c03e57fefa74429eb1cdcc7d4218c11f?variant=devin