Skip to content
This repository was archived by the owner on Nov 21, 2023. It is now read-only.
This repository was archived by the owner on Nov 21, 2023. It is now read-only.

Main section of Bower config does not work correctly with Wiredep #177

Description

@sarahquigley

Hi @terrymun ,

I use Wiredep for automatic injection of dependencies in many of my projects (technically I use grunt-wiredep). I'm using Fluidbox in one of my projects, and found that you have configured the main section of your bower.json file in a way that isn't compatible with Wiredep. (Wiredep did not pick up on Fluidbox's javascript files, and did not automatically inject them as dependencies.)

To fix this, I ended up overriding the bower.json main configuration for Fluidbox in my own bower.json file as follows:

 "overrides": {
    "fluidbox": {
      "main": [
        "dist/js/jquery.fluidbox.min.js",
        "dist/css/fluidbox.min.css"
      ]
    }
  }

I believe the above is the current expected convention for bower.json main paths.

While this overrides solution is working for me, it would be nice if this could be fixed Fluidbox's bower.json config to adhere to convention and so that anyone else who uses Wiredep for dependency injection will not encounter the same problem.

If you're interested in fixing this issue, I'd be willing to submit a PR.

Many thanks,

Sarah

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions