Repository navigation
fix(android): center scan frame after enabling and layout changes - #822
Draft
maharshi-coding wants to merge 1 commit into
Draft
maharshi-coding wants to merge 1 commit into
maharshi-coding wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #576; complements #812.
Re-enabling
showFrameon an already laid-out Android camera creates an overlay whose measured dimensions are still zero. The frame becomes a 53×53-pixel corner fragment. CalculateframeRectfrom actual layout bounds inonSizeChanged()and use those bounds when changing the custom frame size.Adds four Robolectric regression tests and runs them with the Android example build. Measured validation and before/after screenshots are included.
Validation performed locally:
d218635: all 24 independent selection-matrix cases and its 17 existing tests pass, while seven layout checks fail. A separate local composition with this layout patch passes all 54 tests. Those coordinate tests use supplied detections and authored sensor matrices.Local native builds used JDK 17 and an external SDK 36 override because SDK 34 was absent. Baseline TypeScript passes; existing ESLint/Jest commands are blocked by missing
eslint-plugin-import/jest.#710 already changes Android aspect-ratio selection to viewfinder dimensions; #644 changes iOS. Preview grid spacing was unchanged across the six emulator layouts (maximum X/Y difference 0.39%). The original Galaxy A13 stretching/first-load report remains unverified on that hardware. #812 owns barcode coordinate mapping; this PR addresses the separately reproduced visible-frame layout defect, so #576 should remain open.