Repository navigation
fix: agent turn presentation and terminal output for 0.9.1 - #127
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EBTe1N41dch5obbPEEoBvy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes for how
??turns and command output look in the terminal, found by driving hash in Rex and reading the traces. Patch release material for 0.9.1.Evidence
prog < fileran with stdout not a terminal (no animation),prog > filegot a terminal (escape codes in the file),prog 2> filesent stderr to the screen and left the file empty.After: all three match bash (
TestExecute_StdinRedirectKeepsTerminalOutput,…StdoutRedirectIsNotATerminal,…StderrRedirectReachesFile).After:
TestStreamingRenderer_ChunkSplitInvariantandFuzzStreamingRendererSplit: rendering a reply split at any point equals rendering it whole.jj stautspre-typedjj git fetch; a revset typo offeredjj git push -b …one keystroke away.After:
TestExtractPattern_KeepsQuotedWordFromCommand,TestShell_TentativeFixIsNotGhosted.TestPluginCompleter_ServesStaleWhileRefreshingfailed about 1 run in 200 (on master too).After: 0 in 1000; the stale entry is read before the refresh starts.
go test ./...,go vet ./..., golangci-lint v2.14.0 (0 issues), the five PR fuzz targets for 30s each.Merge Danger
Door: two-way
All changes are behavioral fixes with no stored-data or config migrations. Revert by reverting the commits.
Blast Radius: terminal-presentation
Every
??turn renders through the new wrapper, and every interactive external command goes through the new terminal rule in the executor. A regression would show as garbled agent output or a program that no longer sees a terminal. One known difference from bash remains: an upstream pipeline stage's stderr is not a terminal (hash keeps capturing it for learned fixes).