Conversation
Blog cards and post headers hot-linked every author picture from GitHub (avatars.githubusercontent.com on cards, github.com/<user>.png on posts). Ad and tracker blockers drop those requests, so readers saw broken image icons next to the author names. The avatars now live in src/hive/assets/avatars, one PNG per GitHub login, downloaded by scripts/hive/fetch-avatars.ts (pnpm fetch:avatars) and committed. Astro emits them as 1x and 2x WebP. An author without a saved file, such as one whose GitHub account no longer exists, gets an initials badge instead of a request to a third party. The script is not part of fetch-all on purpose: the build must not depend on GitHub being reachable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (44)
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💻 Website PreviewThe latest changes are available as preview in: https://pr-2014.guild-dev-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Author pictures on the Hive blog index and post pages were hot-linked from GitHub (
avatars.githubusercontent.comon cards,github.com/<user>.pngon posts). The URLs work, but ad and tracker blockers drop them, so readers with one saw broken image icons next to every author name.website/src/hive/assets/avatars/<github>.png, 44 files at 160px (about 15 KB each), downloaded by the newscripts/hive/fetch-avatars.tsfrom the author registry insrc/hive/lib/authors.ts. Runpnpm --filter website fetch:avatarsafter adding an author and commit the file. It is deliberately not part offetch-all, so the build never depends on GitHub.AuthorAvatar.astroemits the local image at 1x and 2x WebP throughastro:assets, and falls back to an initials badge when no file exists (one author's GitHub account is gone, so it 404s from GitHub as well). BothBlogCardandBlogAuthorsuse it.avatars.githubusercontent.comorgithub.com/*.pngURLs.The landing page's team section still hot-links GitHub avatars; that is a separate component and untouched here.
Test plan
astro check, eslint and prettier clean.🤖 Generated with Claude Code