Repository navigation
Conversation
… the edit that turned on errors dropped
…t one on its own, skipped by default and reported with errors
…where the walker reads the disk through the output path
This was referenced Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's suite has failed 19 tests since
eb6136bturned on.withErrors()in the tests (they pass on v6.5.0). This brings it back to green, one cause per commit:const files = await api[type]()line in that edit, so both API types threwfiles is not defined.4a2a6b3) callsnormalizePathwithout importing it.fileSymlink2→ a missing file), which the tests silently skipped while errors were suppressed. With.withErrors(), every test crawling/some/dirorrelative/dirthrewENOENTon it. The link is gone from the shared fixtures, and a broken link now has tests of its own, for both API types: listed by name when symlinks are not resolved, skipped when they are, and reported when.withErrors()is on.\\separator reachesreaddir(ENOENT: scandir 'node_modules\'); the test only passed before because the error was suppressed and an empty result satisfiesevery(). The test is markedtest.failson POSIX only, since on Windows a/separator still works, with a comment saying why. A separate PR fixes the walker, which keeps native paths for the file system, and removes the marker.npx vitest run: 112 passed (106 before, plus 6 new).npx prettier --check __tests__is clean.