Skip to content

Remove the @phpstan-ignore that no longer matches - #5

Open
iGrog wants to merge 1 commit into
thesis-php:0.5.xfrom
iGrog:fix/phpstan-unmatched-ignore
Open

iGrog wants to merge 1 commit into
thesis-php:0.5.xfrom
iGrog:fix/phpstan-unmatched-ignore

Conversation

@iGrog

@iGrog iGrog commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

phpstan currently fails on 0.5.x on every cell of the CI matrix:

src/MessageBus/Handling/Handlers.php:58  No error with identifier assign.propertyType is reported on line 58.

The last green run was on 2026-08-12. Since then PHPStan 2.2.x infers the nested property assignment ($copy->handlers[$messageClass][$qualifier] = $handler) correctly, so the ignore no longer matches, and unmatched ignores are reported as errors. There is no composer.lock and the tooling image floats, so any new CI run (including other open PRs) is red.

Removing the ignore: phpstan ✅ on PHP 8.4 / 8.5 × lowest / highest, tests ✅ (verified locally in the project's Docker images).

Recent PHPStan 2.2.x infers the nested property assignment correctly, so the ignore
is unmatched and phpstan fails on every cell of the CI matrix (8.4/8.5 x lowest/highest).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant