Skip to content

Pgmq: poll again right after a full batch instead of waiting for the next signal #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iGrog wants to merge 2 commits into
base: 0.5.x
Choose a base branch
from
Open

Pgmq: poll again right after a full batch instead of waiting for the next signal #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e33964
Pgmq: poll again right after a full batch instead of waiting for the …
iGrog Oct 7, 2026
b09e52a
Remove the @phpstan-ignore that no longer matches
iGrog Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/MessageBus/Handling/Handlers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public function with(string $messageClass, callable $handler, string $qualifier
}

$copy = clone $this;
/** @phpstan-ignore assign.propertyType */
$copy->handlers[$messageClass][$qualifier] = $handler;

return $copy;
Expand Down
8 changes: 7 additions & 1 deletion src/MessageBus/Pgmq/PgmqTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ public function startConsumer(string $queue, ConsumerHandler $handler): PgmqCons

$iterator = $polls->iterate();

EventLoop::queue(function () use ($queue, $handler, $completion, $watcher, $iterator): void {
EventLoop::queue(function () use ($queue, $handler, $completion, $watcher, $iterator, $polls): void {
$watcher->watch();

try {
Expand Down Expand Up @@ -238,6 +238,12 @@ public function startConsumer(string $queue, ConsumerHandler $handler): PgmqCons
} finally {
EventLoop::cancel($updateVisibilityId);
}

// A full batch means the queue may hold more messages. Inserts that already happened will not
// notify again, so waiting for the next signal would leave the backlog idle for up to $pollInterval.
if (\count($messages) === $this->batchSize && !$polls->isComplete()) {
$polls->pushAsync(null)->ignore();
}
}

$completion->complete();
Expand Down
Loading