Skip to content

soundwire: cadence_master: wait and cancel cdns->work before clock stop #5863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bardliao wants to merge 1 commit into
base: topic/sof-dev
Choose a base branch
from
Open

soundwire: cadence_master: wait and cancel cdns->work before clock stop #5863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions drivers/soundwire/cadence_master.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,6 +1705,13 @@ int sdw_cdns_clock_stop(struct sdw_cdns *cdns, bool block_wake)
return 0;
}

/*
* wait for any in-flight peripheral event handling to complete before stopping the clock.
* No need to disable peripheral interrupts before canceling the work, as the peripheral
* interrupts are already masked before the work is scheduled.
*/
cancel_work_sync(&cdns->work);
Comment thread
bardliao marked this conversation as resolved.

/*
* Before entering clock stop we mask the Slave
* interrupts. This helps avoid having to deal with e.g. a
Expand Down
Loading