Repository navigation
release: v2.6.1 — bound app.notify's event history - #245
Merged
Merged
Conversation
Picks up @simpleworkjs/frontend v0.4.3. app.notify subscribes to every model event for the life of the tab and appended each one to an array nothing ever trimmed, then re-collapsed that whole array on every new event to render 30 rows -- one arriving event cost O(history), on a history that only grew. Reproduced in theta-directory, where a browser killed the tab at 4GB; the proxy UI loads the same shell and the same feed, so it carried the same defect. Also corrects nodejs/package.json, which still said 2.5.3 on a tree released as v2.6.0: that release updated the changelog and was tagged but never bumped the version field. The lockfile had been pinned at 0.4.1, so this also picks up 0.4.2 (notification icons, foreground toasts, app.notify.clear()) and 0.4.1's app.messages.confirm() fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TnJ9iEHU6m7kYxD5fXPfts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
app.notifygrew without bound in any long-lived tab. It subscribes to every model event for the life of the page and appended each one toevents, which nothing ever trimmed — the existing cap was on rendered rows, not retained events. Worse,push()callsrender(), which re-collapsed the entire array on every event to produce 30 rows. One arriving event cost O(history), on a history that only grew.Reproduced in theta-directory, where a browser killed the tab at 4GB. The proxy UI loads the same shell (
top.ejs) and the same feed, so it carried the same defect — just at a lower event rate.Fixed upstream in
@simpleworkjs/frontendv0.4.3: history capped atmaxEvents(1000), andcollapse()stops once it has enough groups. Collapsing is strictly local, so rendered rows are byte-identical.nodejs/package.jsonsaid2.5.3on a tree released as v2.6.0. The v2.6.0 release commit (96acbe9) updated the changelog and was tagged and released, but never bumped the version field — so the package has been reporting a three-release-stale version. Corrected here rather than left to drift further, which is why this is 2.6.1 and not 2.6.0.Changed
@simpleworkjs/frontend^0.4.0→^0.4.3. The lockfile had been pinned at 0.4.1, so this also picks up 0.4.2 (notification model icons, foreground toasts,app.notify.clear()) and 0.4.1'sapp.messages.confirm()fix.Dependency and version metadata only — no application code changed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TnJ9iEHU6m7kYxD5fXPfts