Repository navigation
release: v2.6.2 — drop the Font Awesome SVG-with-JS build - #246
Merged
Merged
Conversation
top.ejs pulled both the webfont stylesheet and js/all.min.js. The JS build runs a MutationObserver over the whole document, rewriting every <i> into an <svg> and keeping the original source. On a page that re-renders a list often it cannot keep up: measured in Chrome, 150 rows x 6 rebuilds froze the renderer at 776MB having converted zero icons, while the same run without it was untroubled. The stylesheet alone renders the same fa-solid fa-* classes with no scripting, and nothing in this app uses an SVG-only feature (fa-layers, power transforms, masks). Found in theta-directory; the proxy loads the same shell, so it carried the same cost. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TnJ9iEHU6m7kYxD5fXPfts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs/views/top.ejspulled both the Font Awesome webfont stylesheet andjs/all.min.js. The JS build runs a MutationObserver over the whole document, rewriting every<i>into an<svg>withkeepOriginalSource: true.On a page that re-renders a list often it cannot keep up. Measured in Chrome on identical markup:
It ended with 900
<i>and 0<svg>— it never drained its own backlog.The stylesheet alone renders the same
fa-solid fa-*classes with no scripting, and I checked that nothing in this app uses an SVG-only feature (fa-layers,data-fa-transform,data-fa-mask,i2svg).Found while investigating theta-directory; the proxy loads the same shell, so it carried the same cost.
View change only — no application logic touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TnJ9iEHU6m7kYxD5fXPfts