Repository navigation
feat: v2.7.0 - notification bell filtering - #247
Merged
Merged
Conversation
The feed subscribed to every model event the socket delivered and showed all
of them -- right for a change log, wrong for a person. 0.5.0 adds muting
("Resource:update", "Resource", "*:update"), persisted per-app, and a filter
UI built from the models actually present in the feed. views/top.ejs gains
the #notify-filters container those controls render into; without it muting
still works via config, it just has no UI, and a filter nobody can reach is
not a filter.
Also fixes a burst of events raising a burst of toasts: the feed popped one
toast and one desktop notification per arriving event while its own list
collapsed correctly, so a sweep producing one tidy "42 resources updated" row
also stacked 42 toasts beside it.
^0.4.3 does not admit 0.5.0 -- caret on 0.x pins the minor -- so this is an
explicit bump.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TnJ9iEHU6m7kYxD5fXPfts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up
@simpleworkjs/frontend0.5.0. No application code changed here.Why
The notification feed subscribed to every model event the socket delivered and showed all of them. Right for a change log, wrong for a person: most of the volume is routine churn, and the events worth seeing were buried in it.
0.5.0 adds muting, in three key shapes:
Resource:updateResource*:updateA mute is a view, not a filter on what is recorded — unmuting shows the history you had been ignoring rather than a gap. Preferences persist per-app in
localStorage.views/top.ejsgains the#notify-filterscontainer the controls render into. Without it muting still works through config, it just has no UI — and a filter nobody can reach is not a filter.Also fixed upstream
A burst of events raised a burst of toasts: the feed called
collapse([event])on an array of exactly one event — a no-op wrapper — so every arriving event popped its own toast and desktop notification, while the bell list collapsed correctly. Popups now buffer briefly and collapse the same way the list does.Note on the range
^0.4.3does not admit0.5.0— caret on0.xpins the minor — so this is an explicit bump rather than something a lockfile refresh would have picked up.🤖 Generated with Claude Code
https://claude.ai/code/session_01TnJ9iEHU6m7kYxD5fXPfts
Drive-by: root
package.jsonread2.6.0on a tree released asv2.6.2. Nothing consumes that field, which is exactly why it keeps drifting; both manifests now agree at2.7.0.