Repository navigation
Conversation
This fixes an issue where resources for tests (such as images) aren't copied, causing tests to fail. This happens because building a specific executable target such as skunit_tests doesn't run the custom targets used for the copy. This could be fixed by altering CMakeLists.txt but updating this guide is simpler.
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
connorclancydev
left a comment
There was a problem hiding this comment.
General Information
Update to documentation website clarifying unit tests and regular tests, their differences and explainng in more detail how they work
- Documentation update
Code Quality
The code is easy to read and should be able to be maintained rather easy as well looking through I dont see any mistakes in it including minor grammar mistakes
Functionality
The code fulfills its function and doesnt damage any other functions anything that it removed has been clarified in the code that was added
Testing
Files formatted correctly lint checker didnt have any issues and was able to be successfully built, all lint checks passed and additionally I was able to open the website successfully without finding any issues when opened on my local machine
Pull Request Details
The intention of the pull request has been completed including the additional changes that were made after all the checklist items in the PR were also right
Description
This PR is a copy of #150, created by former contributor @dijidiji. The original PR had tests failing, which I have fixed along with some minor updates:
Original Description (#150)
I've revised and updated the unit testing guide. I've also merged previous testing instructions for
sktestwith relevant instructions that were part of the unit testing guide, since the build process builds both. As part of this, I've elaborated on the differences betweensktestandskunit_testsa bit, and moved the part of the guide that outlined how to write a unit test to a separate page.This way, someone following the guide is made aware of how to run both test programs, and is informed of how to add tests to either of them (as well as the reasons for doing so).
Type of change
How Has This Been Tested?
Made sure the guide looks good in local testing.
Testing Checklist
npm run formatnpm run buildnpm run devand/ornpm run preview, using:Checklist