Repository navigation
Fix labels on plugin_repo build def - #3651
Merged
SpangleLabs merged 1 commit intoNov 5, 2026
Merged
SpangleLabs merged 1 commit into
SpangleLabs merged 1 commit into
Conversation
The extract_rule overrides the remote_rule, which means the labels for the remote_rule will never be seen. We need instead to set the labels on the extract_rule, so we actually get the resulting labels. We can't put them on the subrepo rule because it's not a real rule in the same way. But that also means we don't have to worry about the subrepo overriding it from the extract rule
peterebden
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extract_rule overrides the remote_rule, which means the labels for the remote_rule will never be seen. We need instead to set the labels on the extract_rule, so we actually get the resulting labels. We can't put them on the subrepo rule because it's not a real rule in the same way. But that also means we don't have to worry about the subrepo overriding it from the extract rule
This is a fix for my last PR, #3650 , basically