Repository navigation
Fix equality comparisons on frozen dicts / lists - #3657
Open
peterebden wants to merge 3 commits into
Open
peterebden wants to merge 3 commits into
peterebden wants to merge 3 commits into
Conversation
chrisnovakovic
approved these changes
Nov 9, 2026
toastwaffle
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while working on #3656; equality comparisons never compare equal for frozen lists or dicts (they really should do if they have the same contents).
This fixes by adding an
Equalsmethod onpyObjectwhich can implement this sensibly, losing thereflect.DeepEqualcall. It's more code but I think better.