Fix EMA updates across gradient accumulation and resume - #125
Open
zjn20030811 wants to merge 2 commits into
Open
Fix EMA updates across gradient accumulation and resume#125zjn20030811 wants to merge 2 commits into
zjn20030811 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global_stepwhen the sidecar is absentMotivation
The training loop currently calls
ema_model.step()after every microbatch. Accelerate suppressesoptimizer.step()inside a gradient-accumulation window, but the standalone EMA update is not suppressed. With accumulation factor N, this advances the EMA warmup schedule N times per optimizer update, repeatedly averages unchanged parameters, and performs N full traversals of the 1B-parameter model.Resume has a separate schedule discontinuity: only the averaged weights are loaded, while
EMAModel.optimization_stepstarts again at zero. The next EMA update therefore uses zero decay and overwrites the loaded history with the online model.This change keeps the existing
global_stepdata-consumption semantics while tracking successful EMA updates independently. New checkpoints resume the exact schedule; old checkpoints continue to load with an explicit best-effort migration.Validation
python -m pytest tests/test_ema_model.py -q— 6 passed with Accelerate 0.30.1py_compile, andgit diff --check