Block pull requests without a cross-SDK parity decision

[brionmario]

Purpose

A capability that ships here usually has to ship in the other ThunderID SDKs too, and until now nothing at review time asked whether it did. The SDK development specification states that the parity decision is made on every pull request; this wires that up, as the second half of the proposal in thunder-id/thunderid#5354.

Approach

Every pull request must carry exactly one of parity/prs-raised or parity/prs-not-needed. The check stays red until it does, and no path based heuristic clears it, so a change is never waved through on the strength of the files it happened to touch. Applying the label re-runs the check, so it goes green without a push.

parity/prs-raised also has to be true: it asserts the capability reaches the other SDKs, so every sibling needs a disposition before it passes, being a linked pull request, a linked tracked issue where the port is deferred, or a line naming the repository and saying the change does not reach it.

Alongside the gate, the check keeps a single comment listing the sibling SDK repositories and ticks the boxes itself as port links appear in the pull request body or in replies on the thread, so nobody maintains that list by hand.

The logic lives in thunder-id/thunderid, next to the specification it enforces, and is shared by all four SDK repositories, which cannot drift as a result. This file owns only the triggers, which a reusable workflow cannot declare for its caller, and passes nothing: the sibling list is derived from the repository the check runs in.

The pull request template gains the matching line.

Testing

The shared workflow was exercised against a stubbed github-script environment and then dry run end to end on a throwaway pull request, which confirmed it blocks the pull request red with the checklist comment, goes green the moment the label is applied without a push, and updates its comment in place rather than posting again. Details in thunder-id/thunderid#5410.

Related Issues

• Define a process to ensure feature parity across ThunderID SDKs thunderid#5305

Related PRs

• Add the cross-SDK parity check workflow thunderid#5410 adds the shared workflow this calls, and trims the specification to match. It has to merge first, or the uses: reference here does not resolve.
• The same caller is raised in every SDK repository:
  • Block pull requests without a cross-SDK parity decision #102
  • Block pull requests without a cross-SDK parity decision ios-sdks#24
  • Block pull requests without a cross-SDK parity decision android-sdks#31
  • Block pull requests without a cross-SDK parity decision flutter-sdks#40

Notes for merging

• The two labels have to exist in this repository, or the gate cannot be cleared.
• The required check to add to branch protection is 🔀 Cross-SDK Parity / 🏷️ Parity Decision. Renaming either job later breaks the protection rule.

Checklist

• Followed the contribution guidelines.
• Manual test round performed and verified.
• Documentation provided. (Add links if there are any)
  • The workflow header and the linked specification.
• Tests provided. (Add links if there are any)
  • Unit Tests
  • Integration Tests
• Breaking changes. (Fill if applicable)
  • Breaking changes section filled.
  • breaking change label added.
• Cross-SDK parity. Exactly one of parity/prs-raised or parity/prs-not-needed added.
  • If parity/prs-raised, the port links are posted as a reply on the parity check's comment.

Security checks

• Followed secure coding standards.
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: thunder-id/javascript-sdks/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6cb96591-3c92-43c1-b04a-2764cb7e9441

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}