poll: drop the modal delay from 10s to 3s - #16
Merged
Merged
Conversation
Teodor's call, for response volume. Ten answers in the first day, so the mechanism works; he wants more of them. Recording the trade rather than quietly changing a number: 10s was chosen so the dialog landed after real engagement instead of on arrival, which is the pattern Google's intrusive-interstitial guidance targets, and this site lives on organic search. At 3s that protection is largely gone. The header comment now says so, and names this constant as the first thing to revert if organic impressions on /strada/ and /punct-termic/ dip. TSC clean, 122 unit, 9 e2e (the suite drives the delay from playwright.config.ts, so it is unaffected by the default). Co-Authored-By: Claude Code <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified: single-constant change (DELAY_MS 10s→3s) plus a comment rewrite recording the tradeoff and rollback trigger, exactly matching the PR description. No security surface. Confirmed the e2e suite is decoupled via its own POLL_DELAY_MS override in playwright.config.ts, so no test updates were needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teodor's call, for response volume. Ten answers landed in the first day, so the mechanism works; he wants more of them.
The trade, recorded rather than quietly made
10s was chosen so the dialog appeared after real engagement instead of on arrival — the pattern Google's intrusive-interstitial guidance targets. This site lives on organic search: ~2,095 of 2,353 sitemap URLs are indexed and it is the top-scoring property in SEO Sentinel's portfolio pass.
At 3s that protection is largely gone. The component's header comment now says exactly that, and names
DELAY_MSas the first thing to revert if organic impressions on/strada/and/punct-termic/dip in GSC over the next few weeks.Not a blocker, and the risk is often overstated — page experience is a minor ranking signal. But it should be a decision on the record, not a silent constant change.
Checks
tscclean, 122 unit, 9 e2e. The e2e suite drives the delay fromplaywright.config.ts, so it is unaffected by the production default.🤖 Generated with Claude Code