Repository navigation
docs: say what the server does and how to use it in VS Code - #65
Merged
Merged
Conversation
…in it The registry reads every directory one level below a workspace folder, and a project's own app, Resources and i18n directories are among them. Each one without a tiapp.xml logged a line, so opening one project logged six or seven lines saying nothing was wrong. A directory without a tiapp.xml is now silent. A workspace folder that yields no project at all says so once, when it is added; refresh runs before every request and stays quiet. A tiapp.xml that is turned away still says why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAKDFVwAZoxefLNvX45pE4
The README described tiapp.xml completion and nothing else, gave the development Node version as if it were the runtime one, and never said the command needs --stdio. It now lists the features by file, the requirements, installing from git until it is published, editor setup for VS Code, Neovim and any other client, bundling it in an extension, and where to look when nothing answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAKDFVwAZoxefLNvX45pE4
Neovim, other clients, a global install and bundling in an extension come back with the editors beyond VS Code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAKDFVwAZoxefLNvX45pE4
There was a problem hiding this comment.
🟡 Changes recommended
The README overstates support for code actions and unverified non-VS Code clients.
1 open finding
What changed in this PR
Expands user documentation and reduces noisy project-discovery logging.
Changes:
- Documents supported features, requirements, VS Code usage, troubleshooting, and development commands.
- Consolidates missing-project logs while preserving rejection reasons.
- Adds registry logging tests.
| File | Description |
|---|---|
README.md |
Expands usage and feature documentation. |
src/core/project.ts |
Silences expected missing-tiapp.xml candidates. |
src/core/registry.ts |
Logs one summary for roots without valid projects. |
src/test/core/registry.test.ts |
Tests the revised logging behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The server advertises code actions only to a client that declares codeActionLiteralSupport, because an action carries its edit rather than a command, so the opening promised them to more clients than receive them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAKDFVwAZoxefLNvX45pE4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README
The README described
tiapp.xmlcompletion and nothing else, and gave the Node version development needs as if it were the one the server needs. It now covers:tiapp.xml. Every feature listed is one the test suite covers.tiCLI is optional, and npm with a network connection is needed the first time a project needs a given version of the types.titanium.languageServer.enabledswitches back to the old features for that release.test:package.Other editors, a global install with
--stdio, and bundling the server in another extension are left out for now. They come back with Phase 3 (#24).Logging fix
This branch also carries
fix(registry), which came first:app,Resources,i18nand so on are all checked. Each one without atiapp.xmllogged a line, so opening a single project logged six or seven lines.tiapp.xmlis silent. A workspace folder with no project at all logs one line when it's added and stays quiet on the check that runs before every request. Atiapp.xmlthat's turned away still says why.registry.test.ts, two of which failed before the fix. The full suite passes: 1222 tests, 99.6% of lines covered.🤖 Generated with Claude Code
https://claude.ai/code/session_01AAKDFVwAZoxefLNvX45pE4
Generated by Claude Code