Repository navigation
chore: cleanup references and redundant tests - #68
Open
ewanharris wants to merge 3 commits into
Open
ewanharris wants to merge 3 commits into
ewanharris wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Publishing bypasses the end-to-end checks required by the documented release process.
1 open finding
What changed in this PR
Prepares the language server for publication as @titanium-sdk/language-server and removes the package-test tier.
Changes:
- Renames the package, sets version
0.1.0, and updates metadata. - Adds a release-triggered npm publishing workflow.
- Removes package tests and the empty
CustomRequestsexport.
| File | Description |
|---|---|
| src/test/package/installed-command.test.ts | Removes built-command tests. |
| src/test/package/entry-points.test.ts | Removes entry-point tests. |
| src/test/package/consumer.test.ts | Removes TypeScript consumer tests. |
| src/test/package/built.ts | Removes package-test helpers. |
| src/test/package/alloy-library.test.ts | Removes shipped-declaration tests. |
| src/server.ts | Updates package name in a comment. |
| src/index.ts | Removes CustomRequests; updates documentation. |
| src/core/constants.ts | Removes an issue reference from a comment. |
| README.md | Updates repository link and test commands. |
| package.json | Updates package metadata; removes package-test script. |
| package-lock.json | Synchronizes package name and version. |
| AGENTS.md | Documents releases and updates package references. |
| .github/workflows/publish.yml | Adds trusted npm publishing. |
| .github/workflows/ci.yml | Removes the package-test job. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames project to
@titanium-sdk/language-server, removes some pointless tests and sets up a publish workflow.Workflow can't be used for first publish as it uses trusted publishing which can't be used on the first publish.