Repository navigation
DOCS-3131: Raise dompurify and js-yaml pins and remove unused mermaid theme - #3152
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The critical tinypool major-version compatibility issue must be resolved before approval.
1 open issue
What changed in this PR
This pull request raises dependency resolutions for patched dompurify and js-yaml versions, removes the unused Mermaid integration, and refreshes the lockfile.
Changes:
- Updates security-related dependency resolutions and transitive packages.
- Removes the unused Mermaid theme and Markdown configuration.
- Removes Mermaid-related packages from
yarn.lock. - Adds
tmpandtinypoolresolutions.
The tinypool resolution in package.json forces version 2.2.0 while Docusaurus still declares compatibility with ^1.0.2, creating a critical dependency-contract risk that must be addressed.
| File | Description |
|---|---|
yarn.lock |
Records patched dependency versions and removes unused Mermaid-related packages. |
package.json |
Updates dependency resolutions and removes the Mermaid theme dependency; the tinypool resolution requires correction or a compatible Docusaurus upgrade. |
docusaurus.config.js |
Removes Mermaid Markdown support and theme registration. |
Review effort: Lite
| "prismjs": "1.30.0" | ||
| "patch-package/tmp": "^0.2.6", | ||
| "prismjs": "1.30.0", | ||
| "tinypool": "^2.2.0" |
There was a problem hiding this comment.
This override comes from #3150. A clean local build with DOCUSAURUS_PERF_LOGGER=true showed the 10-thread SSG pool running all 297 tasks on tinypool 2.2.0. The HTML for all 2982 pages matched main. Docusaurus 3.10.1 uses only options that tinypool 2 still supports, and the Docusaurus 4 canary already depends on tinypool ^2.1.2.
5a66aa8 to
96cc29c
Compare


Raises the dompurify and js-yaml resolutions to patched versions, and removes the mermaid theme, which no page uses. This closes 17 Dependabot alerts (dompurify, js-yaml 4, katex, tmp).
https://tigera.atlassian.net/browse/DOCS-3131
Preview: https://deploy-preview-3152--tigera.netlify.app/calico/latest/reference/rest-api-reference/