Skip to content

Bump Node to 22.23.4 #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctauchen merged 2 commits into from
Oct 23, 2026
Merged

Bump Node to 22.23.4 #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45622c7
Bump Node to 22.23.4
ctauchen Oct 23, 2026
2707cb2
Update remaining Node 22.17.0 pins
ctauchen Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ Examples:
## Critical Setup Requirements

### Node.js Version (CRITICAL)
- **Required**: Node.js v22.17.0 or later
- **Required**: Node.js v22.23.4 or later
- **Why Critical**: Build fails with earlier versions (tested with v20.x)
- **Setup**: Use nvm if available: `nvm install 22.17.0 && nvm use 22.17.0`
- **Setup**: Use nvm if available: `nvm install 22.23.4 && nvm use 22.23.4`

### Package Manager Setup (CRITICAL)
1. **Enable Corepack**: `corepack enable` (required for containerized builds, recommended for local development)
Expand Down Expand Up @@ -311,8 +311,8 @@ yarn test:screenshots # Visual regression tests (optional)

### Node Version Issues
- **Problem**: Build fails with "Cannot find package '@docusaurus/logger'"
- **Solution**: Ensure Node.js v22.17.0+, run `corepack enable` first
- **Validation**: `node --version` should show v22.17.0+
- **Solution**: Ensure Node.js v22.23.4+, run `corepack enable` first
- **Validation**: `node --version` should show v22.23.4+

### Yarn Issues
- **Problem**: "packageManager": "yarn@4.9.2" error with global yarn
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.17.0
v22.23.4
4 changes: 2 additions & 2 deletions .semaphore/semaphore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ blocks:
prologue:
commands:
- checkout
- sem-version node 22.17.0
- sem-version node 22.23.4
- node --version
- corepack enable
- yarn --version
Expand All @@ -40,7 +40,7 @@ blocks:
prologue:
commands:
- checkout
- sem-version node 22.17.0
- sem-version node 22.23.4
- corepack enable
- node --version
- yarn --version
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

| | Native | Docker |
|---------------|-------------------------------------------------|-------------------|
| **Requires** | Node.js v22.17.0+ (see `.nvmrc`), Corepack | Docker |
| **Requires** | Node.js v22.23.4+ (see `.nvmrc`), Corepack | Docker |

Check failure on line 46 in README.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'Corepack'?

Raw Output:
{"message":"[Vale.Spelling] Did you really mean 'Corepack'?","location":{"path":"README.md","range":{"start":{"line":46,"column":53},"end":{"line":46,"column":61}}},"severity":"ERROR","code":{"value":"Vale.Spelling"}}
| **Setup** | `nvm use && corepack enable` | Just have Docker running |

This project uses Yarn 4.9.2, managed via [Corepack](https://nodejs.org/api/corepack.html). You must run `corepack enable` before any yarn commands.
Expand Down Expand Up @@ -260,7 +260,7 @@

| Problem | Solution |
|---|---|
| Build fails with "Cannot find package '@docusaurus/logger'" | Wrong Node version. Need v22.17.0+ (check `.nvmrc`). |
| Build fails with "Cannot find package '@docusaurus/logger'" | Wrong Node version. Need v22.23.4+ (check `.nvmrc`). |
| `packageManager` yarn error | Run `corepack enable` first. |
| `make clean` fails when dependencies aren't installed | Use `make manual-clean` instead. |
| React version mismatch warnings during `yarn install` | Expected and non-blocking. Safe to ignore. |
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
]
},
"engines": {
"node": ">=22.17.0"
"node": ">=22.23.4"
},
"packageManager": "yarn@4.9.2"
}
Loading