Repository navigation
Allow building integration tests without running them #69
Description
As an alternative, we could check for the PD_ADDR env var and pass the test if it is not present (or ignore it if it is not present at compile time?).
My reasoning is that when working on the library, it is nice to check that the integration tests still compile, even if we don't run them. Given we don't run them by default today, I don't think passing by default will give a false sense of security.
@Hoverbear what do you think?
Activity
Hoverbear commentedon Jun 19, 2019
Is it possible to do
no-runon tests based on feature flags? Maybe we could use this feature to just enable running the tests (not building of them, which is always)?nrc commentedon Jun 19, 2019
Good question! I think it should be possible, just a
cfg_attrand that would be a good solution if it works.Hoverbear commentedon Jun 20, 2019
Hmmm let me try it!
Hoverbear commentedon Jun 20, 2019
@nrc If we still require
property-testingfeature is that ok? Unfortunately due to theproptestmacro it's difficult to include it in the build without that feature.Fixes tikv#69
Update to reflect #69
nrc commentedon Jun 20, 2019
moving discussion to #68 since I'm finding it difficult to flick between tabs :-)
[-]Remove `integration-tests` feature?[/-][+]Allow building integration tests without running them[/+]