Repository navigation
Conversation
isPreviewEnvironment() only recognized Vercel, GitHub Actions, GitLab, and generic CI, even though getPreviewBranchName() already supported CircleCI, Azure Pipelines, and Bitbucket Pipelines branch names. Add PR-context detection for those three providers (CIRCLE_PULL_REQUEST, SYSTEM_PULLREQUEST_PULLREQUESTID, BITBUCKET_PR_ID) so the SDK treats them as preview environments too, bringing the TS SDK to parity with the Python SDK's provider list. Fixes PROTM-2268 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPreviewEnvironment()insrc/client/preview.tsonly recognized Vercel, GitHub Actions, GitLab, and generic CI as preview environments, even thoughgetPreviewBranchName()already had branch-name support for CircleCI, Azure Pipelines, and Bitbucket Pipelines.CIRCLE_PULL_REQUEST(set to the PR URL when a build is triggered by a pull request)SYSTEM_PULLREQUEST_PULLREQUESTID(set only on PR-triggered pipeline runs)BITBUCKET_PR_ID(set only when the pipeline is triggered by a pull request)Linear issue: https://linear.app/tinybird/issue/PROTM-2268/typescript-sdk-broaden-ci-provider-auto-detection
Test plan
src/client/preview.test.tsfor each new provider, covering both the true (PR env var set) and false (only branch env var set, no PR indicator) conditionspnpm typecheckpassespnpm test:runpasses (1071/1071 tests, including 31 inpreview.test.ts)🤖 Generated with Claude Code