Repository navigation
fix(security): clear the October urllib3 / brace-expansion advisories, accept no-fix braces (INF-3001) - #63
Conversation
… (INF-3001) - langchain: urllib3 2.7.0 -> 2.8.0 (GHSA-vxq7-64xx-v4gw, GHSA-8988-9cw3-xx77, GHSA-gh4c-6fx4-qh6g) - zapier: brace-expansion override 1.1.18 -> 1.1.21 (GHSA-q2hr-2g5m-vwhr, GHSA-6j4f-fj2g-mc7p, GHSA-qhr7-859c-m2p7) - osv-scanner.toml: time-boxed acceptance for braces GHSA-vfj7-8cjw-p6xm (CVE-2026-93687) - no upstream fix, dev-only via jest, EPSS 0.74% Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe minimum Suggested reviewers: Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The dependency locks match the requested versions, and the braces exception has a review expiry. The known affected dependency path is in Jest development tooling; no concrete production-impacting regression is established, so the PR appears mergeable with normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Clears every open Dependabot alert on
main(4: 2 high, 2 medium) and every finding the repo-widevulnerability-checkgate reports, so the gate goes green again. All of them were published after #60 cleared the repo on 2026-09-28.Part of INF-3001 (Dependabot clear-and-enable, Python cluster).
langchain/poetry.locklangchain/poetry.locklangchain/poetry.lockzapier/package-lock.jsonzapier/package-lock.jsonzapier/package-lock.jsonzapier/package-lock.jsonSupersedes Dependabot #61. #61 bumps only
urllib3, so thezapier/findings keep the repo-wide gate red.What changed
langchain/pyproject.toml: theurllib3floor goes to>=2.8.0.poetry.lockwas regenerated with Poetry 2.4.1, the version in its header; the only change is urllib3.zapier/package.json: the exact-pinned"brace-expansion": "1.1.18"override was what held the package below the fix, since Dependabot can't propose a version past an exact pin. It's now1.1.21.package-lock.jsonwas regenerated withnpm install --package-lock-only --ignore-scripts; the only change is brace-expansion.osv-scanner.tomlwith one time-boxed entry (below). Under the org-wide CODEOWNERS rule, this file needs a@tinyfish-io/security_teamapproval.All changes are limited to manifest and lock-file version bumps plus the scanner config; there are no source code changes.
Risk acceptance:
bracesGHSA-vfj7-8cjw-p6xm<=3.0.3, and 3.0.3 is the latest releaseThe advisory is a stack-overflow DoS triggered by deeply nested brace patterns. Here,
bracesis reachable only throughjest → @jest/core → micromatchinzapier/devDependencies (jestis the only devDependency, and it runs asnpm test). It expands glob patterns from jest's own config and CLI, never external input, and it isn't part of the published Zapier app (dependenciesareagentql-js-common,zapier-platform-coreandlodash). Everynpm auditfinding inzapier/traces back to this same advisory. Remove the entry oncebracesships a fix.Verification
osv-scanner scan -r --config osv-scanner.toml .: No issues found, with 1 filtered (thebracesentry). The control, onmain, showed 10 finding rows.urllib32.8.0,brace-expansion1.1.21.Changelog impact summary
🤖 Generated with Claude Code