Repository navigation
test(composio): drop the sync controller from the raw-coverage expectations - #7151
Conversation
…ations tinyhumansai#7146 removed the composio `sync` controller but the raw-coverage suite still listed it in the schema catalog and called it in the bad-params check, so `rust-core-coverage` has failed on main and on every PR rebased since. The two expectations are removed; the remaining 22 functions are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["expect"]:::impacted
n1["join"]:::impacted
n2["..._build_requests_and_parse_local_envelopes"]:::impacted
n3["...ses_stored_session_and_configured_backend"]:::impacted
n2 -->|calls| n0
n3 -->|calls| n0
n3 -->|calls| n1
n3 -->|tests| n1
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0031 · 33,014 in / 1,709 out · 3,950 cached (12%) · gpt-5.6-luna, glm-5.3-flash
critique: $0.0016 · 13,920 in / 521 out · 2,033 cached (15%) · gpt-5.6-luna
security: $0.0014 · 12,904 in / 512 out · 1,789 cached (14%) · gpt-5.6-luna
description: $0.0000 · 3,944 in / 57 out · 64 cached (2%) · glm-5.3-flash
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Composio raw coverage tests now expect 22 catalog functions. They no longer include the ChangesComposio raw coverage tests
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The raw-coverage expectations match the 22 controllers registered at the reviewed head; 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the count with care, Comment |
Since #7146 removed the composio
synccontroller,tests/raw_coverage/composio_raw_coverage_e2e.rshas failed twice on main and on every PR rebased onto it (composio_controller_schema_catalog_covers_all_declared_functions:left: "unknown", right: "sync";composio_controller_handlers_reject_bad_params_before_network:controller sync registered). #7146 itself merged with the lane red.This removes the two
syncexpectations; the 22 remaining functions are untouched. Verified on a tree at mainf3ff1fe745:cargo test -p openhuman-cli --features "voice inference" --test raw_coverage_all -- composiopasses all 11 tests.Unblocks #7141, #7145 and #7150, whose only red lane is this one.
🤖 Generated with Claude Code
Summary by CodeRabbit