Skip to content

test(composio): drop the sync controller from the raw-coverage expectations - #7151

Merged
sanil-23 merged 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/composio-raw-coverage-after-sync-removal
Oct 8, 2026
Merged

sanil-23 merged 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/composio-raw-coverage-after-sync-removal

Conversation

@sanil-23

@sanil-23 sanil-23 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Since #7146 removed the composio sync controller, tests/raw_coverage/composio_raw_coverage_e2e.rs has failed twice on main and on every PR rebased onto it (composio_controller_schema_catalog_covers_all_declared_functions: left: "unknown", right: "sync"; composio_controller_handlers_reject_bad_params_before_network: controller sync registered). #7146 itself merged with the lane red.

This removes the two sync expectations; the 22 remaining functions are untouched. Verified on a tree at main f3ff1fe745: cargo test -p openhuman-cli --features "voice inference" --test raw_coverage_all -- composio passes all 11 tests.

Unblocks #7141, #7145 and #7150, whose only red lane is this one.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated controller catalog checks to reflect the current set of available functions.

…ations

tinyhumansai#7146 removed the composio `sync` controller but the raw-coverage suite
still listed it in the schema catalog and called it in the bad-params
check, so `rust-core-coverage` has failed on main and on every PR
rebased since. The two expectations are removed; the remaining 22
functions are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@tinysweeper

tinysweeper Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 3b68a8d6e19f
Updated: 1791494375 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 1 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["expect"]:::impacted
  n1["join"]:::impacted
  n2["..._build_requests_and_parse_local_envelopes"]:::impacted
  n3["...ses_stored_session_and_configured_backend"]:::impacted
  n2 -->|calls| n0
  n3 -->|calls| n0
  n3 -->|calls| n1
  n3 -->|tests| n1
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change removes the obsolete `sync` entry and its validation case from the Composio coverage test, matching the currently declared Composio functions. The update is safe to merge. _Code retrieval was unavailable (model: ladder embeddings returned 400 Bad Request: {"error":{"message":"unknown ladder vectors; known ladders are flash (also chat-v1, flash-v1), instant (also no-think, instant-v1), reasoning (also deepseek), max-reasoning (also max-reasoning-v1), deepseek-flash (also reasoning-v1, agentic-v1), deep (also luna), scribe, uncensored, vectors-oai3 (also embeddings-oai3-v1), vision (also vision-v1, multimodal-v1), image (also images-v1, image-v1), vi), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: error sending request for url (http://cortexdb:3141/v1/recall\)\), so this review ran without it._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change updates the Composio coverage test to match the current set of declared functions by removing the obsolete `sync` expectations. It looks safe to merge. _Code retrieval was unavailable (model: ladder embeddings returned 400 Bad Request: {"error":{"message":"unknown ladder vectors; known ladders are flash (also chat-v1, flash-v1), instant (also no-think, instant-v1), reasoning (also deepseek), max-reasoning (also max-reasoning-v1), deepseek-flash (also reasoning-v1, agentic-v1), deep (also luna), scribe, uncensored, vectors-oai3 (also embeddings-oai3-v1), vision (also vision-v1, multimodal-v1), image (also images-v1, image-v1), vi), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: error sending request for url (http://cortexdb:3141/v1/recall\)\), so this review ran without it._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The diff matches the description exactly: it removes the two `sync` expectations (array entry and the bad-params assertion), leaving the other 22 functions untouched. The stated failure symptoms correspond to the removed assertions. Looks safe to merge. _Code retrieval was unavailable (model: ladder embeddings returned 400 Bad Request: {"error":{"message":"unknown ladder vectors; known ladders are flash (also chat-v1, flash-v1), instant (also no-think, instant-v1), reasoning (also deepseek), max-reasoning (also max-reasoning-v1), deepseek-flash (also reasoning-v1, agentic-v1), deep (also luna), scribe, uncensored, vectors-oai3 (also embeddings-oai3-v1), vision (also vision-v1, multimodal-v1), image (also images-v1, image-v1), vi), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: error sending request for url (http://cortexdb:3141/v1/recall\)\), so this review ran without it._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: gpt-5.6-luna, glm-5.3-flash
  • Spend: $0.003106
  • Tokens: 33014 input · 1709 output · 3950 cached · 0 embedding
Head State Pass summary
3b68a8d6e19f ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1791494375)

tinysweeper 0.1.0

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T21:20:24.326579Z 3b68a8d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0031 · 33,014 in / 1,709 out · 3,950 cached (12%) · gpt-5.6-luna, glm-5.3-flash
critique:    $0.0016 · 13,920 in / 521 out   · 2,033 cached (15%) · gpt-5.6-luna
security:    $0.0014 · 12,904 in / 512 out   · 1,789 cached (14%) · gpt-5.6-luna
description: $0.0000 · 3,944 in  / 57 out    · 64 cached (2%)     · glm-5.3-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 8, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ecfaa5ae-5027-45cf-81f1-dbafd78d5ccb
📥 Commits

Reviewing files that changed from the base of the PR and between 5bc93ad and 3b68a8d.

📒 Files selected for processing (1)
  • tests/raw_coverage/composio_raw_coverage_e2e.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The Composio raw coverage tests now expect 22 catalog functions. They no longer include the sync schema or test whether sync rejects a missing connection ID.

Changes

Composio raw coverage tests

Layer / File(s) Summary
Update catalog and parameter expectations
tests/raw_coverage/composio_raw_coverage_e2e.rs
The expected function count changes from 23 to 22. The sync schema expectation and missing-connection-ID test are removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: senamakel

Merge Risk: ⚪ Minimal · up to 3b68a

The raw-coverage expectations match the 22 controllers registered at the reviewed head; sync is no longer exposed, and the remaining required-parameter check is retained. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the sync controller from raw-coverage test expectations.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the count with care,
Twenty-two functions now sit there.
The sync lines hop out of sight,
The test file rests for the night.
One soft thump, then off I go,
Through fields where clover starts to grow.

Comment @coderabbitai help to get the list of available commands.

@sanil-23
sanil-23 merged commit 8959889 into tinyhumansai:main Oct 8, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant