Skip to content

revert: restore the tinyagents pin #7197 moved back (main does not compile) - #7201

Closed
senamakel wants to merge 1 commit into
tinyhumansai:mainfrom
senamakel:restore-tinyagents-pin
Closed

senamakel wants to merge 1 commit into
tinyhumansai:mainfrom
senamakel:restore-tinyagents-pin

Conversation

@senamakel

@senamakel senamakel commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Problem

  • cargo check -p openhuman on main (26c62341) fails with unresolved imports in agent/session_host/runtime_session/tool_rules.rs, tools/rules/ops.rs and agent/subagent_host/tool_prep.rs.

Solution

  • git revert -m 1 b2924d852d: the tinyagents gitlink and the one Cargo.lock line Storage secrets #7197 changed. Nothing else.

Submission Checklist

  • Tests added or updated: N/A, a pin restore.
  • Diff coverage ≥ 80%: N/A, no source lines changed.
  • Coverage matrix updated: N/A.
  • Affected feature IDs: N/A.
  • No new external network dependencies.
  • Manual smoke checklist: N/A.
  • Linked issue: N/A, reverts Storage secrets #7197.

Impact

Related

  • Closes: N/A
  • Reverts Storage secrets #7197.
  • Follow-up PR(s)/TODOs: delete the leftover storage-secrets / storage-cron-flows fork branches, so a stale submodule checkout can't be merged again.

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: restore-tinyagents-pin
  • Commit SHA: see the PR head

Validation Run

  • pnpm --filter openhuman-app format:check: N/A
  • pnpm typecheck: N/A
  • Focused tests: cargo check -p openhuman passes
  • Rust fmt/check (if changed): N/A
  • Tauri fmt/check (if changed): N/A

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

  • Intended behavior change: none.
  • User-visible effect: none.

Parity Contract

  • Legacy behavior preserved: yes.
  • Guard/fallback/dispatch parity checks: N/A.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none
  • Canonical PR: this one
  • Resolution (closed/superseded/updated): N/A

Summary by CodeRabbit

  • Chores
    • Updated a bundled component to a newer revision. The available summary does not specify any changes to end-user features or behavior, so no additional user-facing impact can be confirmed. No other end-user changes are identified for this update.

tinyhumansai#7197 (a leftover storage-secrets branch) moved vendor/tinyagents from
33a86887 back to 37185fdc, which predates the tool-rules API
(ToolRulePolicy, tinytools::ToolRules/Surface) that main's code uses since
tinyhumansai#7175, so main stopped compiling. Restores the pin and the Cargo.lock line.

This reverts commit b2924d8, reversing changes made to d670efc.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T14:45:42.968150Z 28d3875 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc30e1b8-35b1-4a7f-958f-6f6cc0d5fe59

📥 Commits

Reviewing files that changed from the base of the PR and between 26c6234 and 28d3875.


⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)
  • vendor/tinyagents

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.



📝 Walkthrough

Walkthrough

The vendor/tinyagents submodule reference changed to commit 33a86887d52f1dba4e39fdb598b7694c20cfdc84.

Changes

Tinyagents submodule update

Layer / File(s) Summary
Update submodule reference
vendor/tinyagents
The submodule reference changed from 37185fdcfc513ea2d9ea53608c069683975966e0 to 33a86887d52f1dba4e39fdb598b7694c20cfdc84.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: m3ga-mind


Merge Risk: ⚪ Minimal · up to 28d38

This restores the TinyAgents pin, with no concrete regression established. The change appears mergeable; the normal build check should confirm the reported compilation result.

Architecture Summary

Architecture risk: 🔵 Low · up to 28d38

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in vendor/tinyagents: The vendor/tinyagents submodule now references commit 33a86887d52f1dba4e39fdb598b7694c20cfdc84 instead of 37185fdcfc513ea2d9ea53608c069683975966e0.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: reverting the tinyagents pin change from #7197 to restore compilation.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the tiny trail
One commit hops where old ones pale
The vendor path points somewhere new
A quiet change, a single cue
Then paws away beneath the moon

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@tinysweeper

tinysweeper Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 28d3875973bc
Updated: 1791557342 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: None
  • Spend: $0.000000
  • Tokens: 0 input · 0 output · 0 cached · 0 embedding
Head State Pass summary
28d3875973bc ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1791557342)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 9, 2026
@senamakel

Copy link
Copy Markdown
Member Author

Superseded by #7200, which restored the same tinyagents pin (and the app lockfile) on main; this branch has no diff left against main.

@senamakel senamakel closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant