Repository navigation
chore(openapi): deny the admin memory reads at the raw transport - #52
Merged
Merged
Conversation
Sync against tinyhumansai/backend#1414's spec: the five GET /admin/memory/* routes (overview, storage, top-tenants, tenants/{userId}, model-usage) join UNEXPOSED_ROUTES. No typed method. Ratchets: UNEXPOSED_ROUTES 59 -> 64, excludedAdminOperationCount 47 -> 52.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe unexposed route list now includes five admin memory GET routes. The manifest and tests update their route and excluded-operation counts to reflect these additions. ChangesAdmin memory route exclusions
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers:
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: denying admin memory read routes at the raw transport layer. |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the routes at night,
Five memory paths stay out of sight.
The counts now match the list in view,
The tests confirm the boundary too.
Then hops away beneath the moon.
Comment @coderabbitai help to get the list of available commands.
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["..._api_key_request_uses_openapi_field_names"]:::impacted
n1["path_segments_are_encoded_on_typed_routes"]:::impacted
n2["create"]:::impacted
n3["try_from"]:::impacted
n4["get_feedback"]:::impacted
n5["...ejects_the_machine_only_connections_scope"]:::impacted
n0 -->|calls| n2
n0 -->|tests| n2
n1 -->|calls| n4
n1 -->|tests| n4
n5 -->|calls| n3
n5 -->|tests| n3
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0009 · 73,748 in / 4,646 out · 9,982 cached (14%) · gpt-5.6-luna, glm-5.3-flash
critique: $0.0005 · 38,599 in / 2,650 out · 6,152 cached (16%) · gpt-5.6-luna
security: $0.0003 · 23,520 in / 753 out · 3,638 cached (15%) · gpt-5.6-luna
tests: $0.0000 · 4,455 in / 156 out · 64 cached (1%) · glm-5.3-flash
description: $0.0000 · 4,158 in / 137 out · 64 cached (2%) · glm-5.3-flash
tinysweeper
Bot
added
the
priority: p3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Syncs the SDK against the backend spec from tinyhumansai/backend#1414 (
npm run swagger+scripts/sync-openapi.mjs --input), which adds fiveGET /admin/memory/*routes to the raw-transport denylist insrc/generated_public_routes.rs:mainbut never synced: overview, storage, top-tenants,tenants/{userId}GET /admin/memory/model-usageAll five are admin-only; no typed client method is added.
Ratchets
UNEXPOSED_ROUTES59 → 64excludedAdminOperationCount47 → 52Both bumped by exactly the five admin routes above.
Verification
cargo fmt --check,cargo clippy -D warningsandcargo testpass.Follow-up
After this merges, tinyhumansai/backend#1414 moves its
sdkgitlink to the merged commit.Summary by CodeRabbit