Repository navigation
test: rename legacy test.rs and *_test.rs files to *_tests.rs - #44
Conversation
Each module keeps its name; its declaration gains a #[path] to the renamed file. Only names change, no test code does. Drops the legacy-files note from the guidance. Co-authored-by: Medulla <medulla@tinyhumans.ai>
…nto legacy-test-renames
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (23)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTest-only module declarations now select explicit test source paths in the bus crate and the main crate. The testing guidelines no longer instruct contributors to rename existing test files when they next touch them. ChangesTest Module Paths
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change reorganizes test source filenames without changing production behavior. The listed paths match their renamed test files, leaving no concrete merge-blocking risk; routine CI should run the deferred checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
A rabbit checks each test file’s name, Comment |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Could not review: crates/tinychannels-bus/src/adapters/mod.rs, crates/tinychannels-bus/src/channel/mod.rs, crates/tinychannels-bus/src/delivery/segment.rs, crates/tinychannels-bus/src/security/mod.rs, crates/tinychannels-bus/src/text/mod.rs, src/approvals/mod.rs, src/delivery/mod.rs, src/delivery/progressive/mod.rs, src/harness/mod.rs, src/relay/mod.rs, src/remote/mod.rs, tinysweeper/description, tinysweeper/tests Before merge
How this fits togetherflowchart LR
n0["constant_time_eq<br/>changed"]:::changed
n1["turn"]:::impacted
n2["try_pair_blocking"]:::impacted
n3["text_delta_uses_draft_when_editing_supported"]:::impacted
n4["...s_to_text_when_native_actions_unavailable"]:::impacted
n5["media_event_projects_media_urls"]:::impacted
n2 -->|calls| n0
n3 -->|calls| n1
n3 -->|tests| n1
n4 -->|calls| n1
n4 -->|tests| n1
n5 -->|calls| n1
n5 -->|tests| n1
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinychannels-bus/src/adapters/mod.rs, crates/tinychannels-bus/src/channel/mod.rs, crates/tinychannels-bus/src/delivery/segment.rs, crates/tinychannels-bus/src/security/mod.rs, crates/tinychannels-bus/src/text/mod.rs, src/approvals/mod.rs, src/delivery/mod.rs, src/delivery/progressive/mod.rs and 5 more.
$0.0000 · 0 in / 0 out · 543 embedded · ladder/vectors
tinysweeper
Bot
added
the
priority: p3
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5efe5881c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub use local::{LocalChannelAdapter, LocalOutboundSink}; | ||
|
|
||
| #[cfg(test)] | ||
| #[path = "mod_tests.rs"] |
There was a problem hiding this comment.
When externalizing these suites, this file—and the migrated src/delivery/mod_tests.rs, src/harness/mod_tests.rs, and src/relay/mod_tests.rs files—omits use super::*; entirely and instead imports the module API through crate paths. The repository explicitly requires sibling unit-test files to start with the parent glob import, so normalize these migrated files as part of the rename.
AGENTS.md reference: AGENTS.md:L140-L142
Useful? React with 👍 / 👎.
| }; | ||
|
|
||
| #[cfg(test)] | ||
| #[path = "mod_tests.rs"] |
There was a problem hiding this comment.
After this rename, docs/spec/tinychannels-migration-remaining-plan.md still points readers to the now-deleted src/delivery/test.rs at line 130 and src/relay/test.rs at line 148. Anyone following the G2 or G4 test-coverage notes now reaches nonexistent files; update both references to their new mod_tests.rs paths.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
Renames 11 legacy test files (
test.rsand<name>_test.rs) to<module>_tests.rs(test.rsbecomes<declaring file>_tests.rs,mod_tests.rsbeside amod.rs). Each module keeps its identifier, so references to it keep resolving; its declaration gains a#[path]to the renamed file. Only file names and those attributes change, no test code. Removes the now-stale "legacy files" note from the guidance. Done with OpenHuman'sscripts/externalize-inline-tests.mjs --rename-legacy.Related issue
None.
API or behavior changes
None. Test-only files renamed; no public API or runtime behavior changes.
Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check(clean)cargo clippy --all-targets --all-features -- -D warnings(left to CI)cargo check --workspace --tests(passes;cargo build/cargo testleft to CI)cargo test --all-features(left to CI)Tests
No tests added or changed; 11 files renamed. Test bodies are untouched (git detects them as renames).
Documentation
CLAUDE.md/AGENTS.mdupdated.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the descriptionSummary by CodeRabbit