Skip to content

fix(release): key rust-cache per bundle id - #46

Merged
senamakel merged 1 commit into
mainfrom
fix-release-waproto
Oct 2, 2026
Merged

senamakel merged 1 commit into
mainfrom
fix-release-waproto

Conversation

@senamakel

Copy link
Copy Markdown
Member

The v0.1.9 release failed in Module bundle (ubuntu-22.04-arm64): the waproto build script died with GLIBC_2.39 not found. Root cause: Swatinem/rust-cache keys only on OS family and arch, so the ubuntu-22.04-arm64 and ubuntu-24.04-arm64 matrix legs shared one cache; a build script compiled on 24.04 was restored onto 22.04 (glibc 2.35). Fix: add key: matrix.id so each distro has its own cache. Not a protoc or waproto problem; the build is not skipped.

…ild scripts

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: d717473ac869
Updated: 1790942190 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 2

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Could not review: .github/workflows/release.yml

Before merge

  • Complete the critique review for .github/workflows/release.yml.
  • Complete the security review for .github/workflows/release.yml.
Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: .github/workflows/release.yml
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: .github/workflows/release.yml.

security

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: .github/workflows/release.yml
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: .github/workflows/release.yml.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change adds a per-bundle cache key to the rust-cache action to prevent cache collisions between Ubuntu 22.04 and 24.04 matrix legs. The fix is correct and introduces no new issues. _Code retrieval was unavailable (model: ladder embeddings returned 502 Bad Gateway: {"error":{"message":"no rung of ladder vectors could serve the request","skipped":[{"model":"text-embedding-bge-m3","provider":"venice","reason":"rate limited, retry in 29s","rung":0}],"type":"ladder_router_error"}}), so this review saw the diff alone._ _2 memory call(s) failed (model: cortex: v1/answer: timed out after 20s), so this review saw part of what the engine holds._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: deepseek/deepseek-v4-flash
  • Spend: $0.001177
  • Tokens: 7687 input · 2695 output · 0 cached · 0 embedding
Head State Pass summary
d717473ac869 incomplete 0 active finding(s), 0 resolved finding(s) (at 1790942190)

tinysweeper 0.1.0

@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 9 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1f1ec0e9-288a-4e47-82b4-13190b5e8047

📥 Commits

Reviewing files that changed from the base of the PR and between 9b25c0f and d717473.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T11:56:45.405013Z d717473 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: .github/workflows/release.yml.

             $0.0012 · 7,687 in / 2,695 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0008 · 6,254 in / 1,135 out · 0 cached (0%) · deepseek/deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 2, 2026
@senamakel
senamakel merged commit cd814d9 into main Oct 2, 2026
10 checks passed
@senamakel
senamakel deleted the fix-release-waproto branch October 8, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant