Repository navigation
feat: vendor direct TinyHumans dependencies - #176
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 4 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsPreviously reported and still active
Could not review: Cargo.toml, tinysweeper/description, tinysweeper/e2e, tinysweeper/tests Before merge
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe repository adds pinned ChangesVendored workspace integration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit hops through crates so neat Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8386fd7f10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "vendor/tinyinference/crates/tinyinference-core", | ||
| "vendor/tinyinference/crates/tinyinference-embeddings", | ||
| "vendor/tinyinference/crates/tinyinference-llm", | ||
| "vendor/tinymemory/crates/tinymemory-api", |
There was a problem hiding this comment.
When a new contributor follows gitbooks/getting-started.md:147-154, the documented plain git clone leaves these newly required submodule directories uninitialized, so the first cargo check fails while loading the missing vendored manifests. Although scripts/setup.sh initializes them, this workflow never invokes that script; update it to clone with --recurse-submodules or run git submodule update --init --recursive before Cargo.
Useful? React with 👍 / 👎.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes: 2 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0152 · 304,927 in / 18,286 out · 21,186 cached (7%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 396 embedded
critique: $0.0074 · 137,361 in / 5,706 out · 10,112 cached (7%) · gpt-5.6-luna, deepseek-v4-flash
security: $0.0067 · 123,409 in / 3,140 out · 9,026 cached (7%) · gpt-5.6-luna
tests: $0.0003 · 16,101 in / 1,866 out · 1,024 cached (6%) · deepseek-v4-flash
description: $0.0003 · 7,714 in / 4,237 out · 1,024 cached (13%) · deepseek-v4-flash
e2e: $0.0003 · 16,867 in / 379 out · 0 cached (0%) · deepseek-v4-flash
| members = [ | ||
| ".", | ||
| "api", | ||
| "vendor/tinyinference/crates/tinyinference-core", |
There was a problem hiding this comment.
Do not merge crates from nested workspaces into this workspace
These crates are described as inheriting metadata from the TinyInference upstream workspace, but listing them as members of this root workspace makes them members of this workspace instead. Cargo does not support nested workspaces, and any workspace = true fields in their manifests will resolve against this root's metadata (edition = 2024, rust-version = 1.88, and the TinyInference repository) rather than their upstream workspace. That can make cargo metadata/cargo check fail or silently change the vendored crates' package configuration. Keep the submodule workspace separate and use path dependencies, or remove its own workspace root and explicitly verify every inherited field after making it a member.
[RULE] workspace-membership ·
| tinymemory-api = { git = "https://github.com/tinyhumansai/tinymemory", rev = "4549cda222de3891b95e2fa58e2565bb2c194328" } | ||
| # Vendored as a submodule so this re-export and any local TinyMemory consumer | ||
| # resolve exactly one set of contract types, without a direct Git dependency. | ||
| tinymemory-api = { path = "../vendor/tinymemory/crates/tinymemory-api" } |
There was a problem hiding this comment.
Avoid requiring an uninitialized submodule to build
This path dependency only works when vendor/tinymemory has been populated. A normal git clone does not initialize submodules, and Cargo also does not populate nested submodules when resolving a repository used as a git dependency, so cargo check fails with a missing manifest before tinycortex-api can build. The CI checkout explicitly enables submodules, but that does not protect contributors following the repository's normal clone instructions or downstream users consuming the crate from Git. Keep the dependency self-contained for ordinary checkouts, or add and enforce a documented/bootstrap mechanism that makes every supported source-consumption path initialize the submodule.
[RULE] uninitialized-submodule ·
tinysweeper
Bot
added
the
priority: p1
Co-authored-by: Medulla <medulla@tinyhumans.ai>
tinysweeper
Bot
added
priority: p3
1 participant
Replaces parent-level TinyHumans Git dependencies with paths into vendored submodules pinned to current upstream main.\n\nVerification:\n- TinyHivemind: cargo test --workspace --all-targets\n- TinyCortex: cargo check --workspace --all-targets, focused API/contract tests (full suite has one pre-existing source-weight assertion failure unrelated to this change).
Summary by CodeRabbit