Skip to content

name the live bot login so the guard inspects agent PRs - #11

Merged
pablo-tech merged 1 commit into
mainfrom
fix/guard-bot-logins
Sep 24, 2026
Merged

pablo-tech merged 1 commit into
mainfrom
fix/guard-bot-logins

Conversation

@pablo-tech

Copy link
Copy Markdown
Contributor

The plover-autopilot → pedalion-ci App rename moved the bot login to pedalion-ci[bot]. This repo still named the dead login in two places, and both fail open — the guard has been reporting green on agent pull requests without reading them.

Gate 1 — ci.yml:40. The host's applies step matches the PR author against authors: with grep -qxF, a whole-line match. pedalion[bot] is not pedalion-ci[bot], so an agent PR took the else branch, every later step was if-skipped, and the job still reported success.

Gate 2 — autopilot.json. guard.ts builds the agent's change set as changes.filter(c => c.author === config.agentAuthor), matching the git commit author name. With a dead value that set is always empty, so all five agent rules were inert: forbidden paths, weakened tests, the maxLines cap, "fix adds no unit test", and the unit-test-proof set.

The first of those is the sharp one here: "forbidden": ["**/finding-dag/**/*.md"] protects the frozen ## Reasoning prompt bodies, and until now the agent could have rewritten them with the guard green.

Dependabot was never affected — dependabot[bot] was in the list and botAuthor was correct, so BOT_ALLOWED was enforced throughout. Only the agent half was open.

New values match lexi, pilos, plover-code and pedalion-ci itself, which are all already correct. This repo and tinytars/vault were the last two carrying either dead login.

Merging with [skip ci]: the diff touches only .github/, and the post-merge run would cut a release for it.

🤖 Generated with Claude Code

…ipping them

The plover-autopilot -> pedalion-ci App rename moved the bot login. Both stale values
fail OPEN: the `authors:` list no longer contains the agent, so guard.yml's `applies`
step reports success having checked nothing; and `agentAuthor` never matches a commit
author, so every agent-side rule in guard.ts iterates an empty set -- including the
forbidden-path rule that protects finding-dag's frozen prompt bodies.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@pablo-tech
pablo-tech merged commit f10859f into main Sep 24, 2026
4 checks passed
@pablo-tech
pablo-tech deleted the fix/guard-bot-logins branch September 24, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant