Repository navigation
name the live bot login so the guard inspects agent PRs - #26
Merged
Merged
Conversation
…ipping them The plover-autopilot -> pedalion-ci App rename moved the bot login. Both stale values fail OPEN: the `authors:` list no longer contains the agent, so guard.yml's `applies` step reports success having checked nothing; and `agentAuthor` never matches a commit author, so every agent-side rule in guard.ts iterates an empty set -- the forbidden paths, the weakened-test check, the maxLines cap and the unit-test requirement. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
plover-autopilot→pedalion-ciApp rename moved the bot login topedalion-ci[bot]. This repo still named the dead login in two places, and both fail open — the guard has been reporting green on agent pull requests without reading them.Gate 1 —
ci.yml:33. The host'sappliesstep matches the PR author againstauthors:withgrep -qxF, a whole-line match.pedalion[bot]is notpedalion-ci[bot], so an agent PR took theelsebranch, every later step wasif-skipped, and the job still reportedsuccess.Gate 2 —
autopilot.json.guard.tsbuilds the agent's change set aschanges.filter(c => c.author === config.agentAuthor), matching the git commit author name. With a dead value that set is always empty, so all five agent rules were inert: forbidden paths, weakened tests, themaxLinescap, "fix adds no unit test", and the unit-test-proof set.Dependabot was never affected —
dependabot[bot]was in the list andbotAuthorwas correct, soBOT_ALLOWEDwas enforced throughout. That is why last week's Dependabot batch merged honestly. Only the agent half was open.New values match
lexi,pilos,plover-codeandpedalion-ciitself, which are all already correct. This repo andtinytars/reasoningwere the last two carrying either dead login.Merging with
[skip ci]: the diff touches only.github/, and the post-merge run would publish an@tinytars/vaultrelease for it — as #24 did forv0.1.33.🤖 Generated with Claude Code