Added FaultListResult - #166
Merged
Merged
Conversation
XoMEX
approved these changes
Sep 15, 2026
XoMEX
left a comment
XoMEX
left a comment
Member
There was a problem hiding this comment.
I only dislike the ResultMatcher a bit, but not strongly enough to reject the PR 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some scan properties, we can attribute an issue to a specific subset of features. For further debugging and fixing, it may be nice to print the exact features for the user. However, so far this required a summarizing property documenting if an issue was found (TestResult.TRUE / . FALSE) and a separate ListResult holding the NamedGroup. The new FaultListResult bundles this into one object and re-uses the SummarizableResult interface to determine the final result.
Note that this PR also fixes the comparison of actual results and expected results so we can use SummarizableResults in the scanner's rating influencers. So this PR also adds tests for this.