Conversation
ServerConfig.scope was mutable (`:= null`) for one reason: callers needed to attach a fleet's scope to a config that came from the global CLI config (which never carries a scope). Three sites mutated: FleetFile.init(), the legacy-format reader, and migration-start_. Replaces that with proper clone methods, matching the existing 'with --host' pattern on ServerConfigSupabase: - ServerConfig grows an abstract 'with --scope/Scope -> ServerConfig'. - Each subclass (ServerConfigSupabase, ServerConfigHttp) implements it, returning a fresh instance with all other fields preserved. - The three mutation sites in fleet.toit now build a scoped copy instead. - ServerConfig.scope becomes immutable (the field declaration drops its ':= null' initializer; the field is set via the constructor only).
floitsch
force-pushed
the
floitsch/build-artemis-service.s-new.070
branch
from
May 23, 2026 12:52
980afa4 to
dbaef3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerConfig.scope was mutable (
:= null) for one reason: callers needed to attach a fleet's scope to a config that came from the global CLI config (which never carries a scope). Three sites mutated: FleetFile.init(), the legacy-format reader, and migration-start_.Replaces that with proper clone methods:
with-scope --scope/Scope -> ServerConfig.:= nullinitializer; the field is set via the constructor only).