Repository navigation
feat: adopt lnurlcash-kit 0.8 with BIP-32-derived note secrets - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts
lnurlcash-kit@0.8.0/lnurlcash-conformance@0.7.0and moves all note-secret generation to BIP-32 derivation from a per-wallet cash root, with atomic per-mint counters, pre-wire durability, and cryptographic verification of landed mutation signatures.This is an alpha-breaking storage reset: legacy wallet state is wiped on first boot (no migration), and phrase-only restore recreates wallet identity — note inventory and counters come back via file/Nostr backup.
Key material & unlock
WalletMaterialV2envelope persists linking key + BIP-32 cash root together; linking-key-derived identities (owner ID, Nostr, NWC, bearer encryption, backups) are byte-for-byte unchanged.Fund safety
sattle_funds_v2document (bearers + pending journals + per-host counters + revision): counter reservation and output staging commit in ONE locked write before any mint request; failures write nothing and contact no mint.max); active pending mutations stay device-local.Recovery & signatures
requireSignatures: true/mutationRetries: 1are enforced centrally and cannot be overridden by callers; landed split/merge signatures are verified against trusted current AND previous mint keys — invalid/missing signatures stay staged, unverified, and recoverable.Integration
MintMockernow signs rotate/split/merge with stable mock keys and supports an invalid-signature adversarial mode.Verification
vue-tsc: clean · PWA build: clean · E2E: 28/28 Playwright (4 consecutive runs).omo/evidence/task-8/)Deferred (deliberately out of scope)
restoreFromSeedscanning UI