Skip to content

Typos, round 3 #44

Description

@Firsh

https://www.totaltypescript.com/workshops/typescript-pro-essentials/unions-and-narrowing/combining-union-types-in-typescript/exercise

"There are several different functions here–"

Instead of the long dash, I'd use a :


https://www.totaltypescript.com/workshops/typescript-pro-essentials/unions-and-narrowing/narrowing-with-in-statements/exercise

The tests written below the video are confusing/buggy and don't match what's in the video or what's in the repo.


https://www.totaltypescript.com/workshops/typescript-pro-essentials/unions-and-narrowing/narrowing-with-in-statements/solution

"We can use an in operator to check if a specific key exists on json."
The example code uses response instead of json as the name.

"Using in here allows gives us a great way..."
remove the word allows


https://www.totaltypescript.com/workshops/typescript-pro-essentials/unions-and-narrowing/introducing-the-never-type-in-typescript

Below this text:
"You cannot assign anything to never, except for never itself."

The code snippet would make more sense if it included this from the repo version:

const fn = (input: never) => {};

Because otherwise, the fn function definition is not shown in the text.


https://www.totaltypescript.com/workshops/typescript-pro-essentials/unions-and-narrowing/discriminated-booleans/solution

Possibly broken backtick code markdown around response is successful, the first member of the tuple is
(the words true and User should be surrounded by them, not the explaining text)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions