Re-enable Windows and Linux native tests on matching hosts - #139
Draft
samhill303 wants to merge 5 commits into
Draft
Re-enable Windows and Linux native tests on matching hosts#139samhill303 wants to merge 5 commits into
samhill303 wants to merge 5 commits into
Conversation
samhill303
marked this pull request as draft
September 2, 2026 17:34
The three databasePathRemoves* tests fail on mingwX64. They were added in f59c6b1 along with a mechanical port of the file:// handling to all three File.kt copies, but the mingw tests have never run, so the port was never checked against a Windows host. mingw's File sets separatorChar to a back slash, and both fixSlashes and join compared against it directly. Forward slashes were therefore not separators: "//tmp//" collapsed to nothing, and join saw no trailing separator and inserted one, so File("//tmp//", "testdb") produced "//tmp//\testdb". Windows accepts either slash direction, so treat both as separators and normalize to separatorChar. Paths built from USERPROFILE are unaffected as they already use back slashes; only inputs that previously produced mixed garbage change. fixSlashes also reused the original string whenever the length was unchanged. That held when the only edits were collapsing and truncating, but rewriting slashes in place keeps the length, so drop the shortcut and always rebuild. The tests asserted POSIX separators. Derive the expected separator from Platform.osFamily so they assert the same normalization on every host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft attempt to get windows and linux working in CI
Fixes #
Summary
Implementation notes
Testing
Platforms verified
User-facing impact
Documentation
CLAUDE.md/AGENTS.md), if the repo has themScreenshots or recordings