feat: add offline CDK validate workflow and bump toolchain versions - #25
Merged
Merged
Conversation
- Add cdk-validate workflow that runs `uv run projen validate` on pull requests without AWS credentials - Bump aws-cdk-lib 2.267.0, aws-cdk-cli 2.1139.0, projen 0.103.7, pytest 9.1.1 - Keep GitHub Action versions in one GITHUB_ACTIONS map (checkout v7, setup-python v7, setup-uv v10, configure-aws-credentials v6) and register it with projen so its own workflows use the same major tags - Put src on PYTHONPATH for the test task so `projen build` runs the tests Claude-Session: https://claude.ai/code/session_01Tz9KQF59qSvDQVKBNezGeC
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
astral-sh/setup-uv only publishes floating tags up to v7, so v10 must be referenced by its full release tag. Claude-Session: https://claude.ai/code/session_01Tz9KQF59qSvDQVKBNezGeC
None of the generated workflows push to git, so actions/checkout no longer writes the token into .git/config where later steps could read it. Claude-Session: https://claude.ai/code/session_01Tz9KQF59qSvDQVKBNezGeC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cdk-validateworkflow runsuv run projen validate(cdk validate --no-online) on every pull request. It needs no AWS credentials, so it also runs safely on fork PRs.GITHUB_ACTIONSmap insrc/bin/cicd_helper.py:actions/checkout@v7,actions/setup-python@v7,astral-sh/setup-uv@v10,aws-actions/configure-aws-credentials@v6.pin_github_actionsregisters the map with projen so the auto-approve and pull-request-lint workflows use the same major tags (no commit SHA pins).cdk_environment_stepshelper.srconPYTHONPATH, souv run projen buildactually runs the tests (they failed to importstacksbefore).Validation
uv run projenregenerates cleanlyuv run projen buildpasses (1 test)uv run projen validatereports no problems