Repository navigation
fix(postgres): make hostaddr semantics match libpq - #4514
Merged
Merged
Conversation
abonander
changed the title
hostaddr semantics match libpq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4102 (superceded PR)
Does your PR solve an issue?
N/A
Is this a breaking change?
Minor breaking behavior change:
hostaddr(env:PGHOSTADDR) is no longer treated as an alias forhost, and does not pass through DNS resolution.However, the previous behavior did not match that of
libpqwhich is surprising and unintuitive, and also defeats the purpose of this parameter.What's not implemented in this PR: allowing a comma-separated list of addresses in
hostaddr. If this is behavior you need or desire, please open an issue for discussion before opening a PR.