Repository navigation
Conversation
Require only Send for the owned FnOnce callback. The returned future remains Send, while captures such as mpsc::Receiver are now accepted.
Share regression coverage between PostgreSQL, MySQL/MariaDB, SQLite, and Any connections. Check non-Sync captures, future sendability, commit, and rollback.
shuvroroy
force-pushed
the
fix/4513-transaction-callback-sync
branch
from
November 10, 2026 13:51
3e337ad to
eea4454
Compare
shuvroroy
marked this pull request as ready for review
November 10, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection::transactionrejects callbacks that captureSendbut non-Syncvalues such asstd::sync::mpsc::Receiver. The callback is moved into the returned future and invoked once, so this removes the unnecessarySyncbound while retainingSend.Add a shared regression helper to the native PostgreSQL, MySQL/MariaDB, SQLite, and Any suites. It holds a receiver across an await, checks that the transaction future is
Send, and verifies commit onOkand rollback onErr.Does your PR solve an issue?
Fixes #4513.
Is this a breaking change?
Yes, for custom
Connectionimplementations that overridetransactionwith the oldF: Syncbound: they must relax that bound to match the trait. Existing callers remain compatible. All in-tree drivers inherit the default implementation.Validation
Syncbound and compiles after its removal.--all-features: 11 passed.-D warnings,cargo check -p sqlx-test, formatting, andgit diff --checkpassed.